forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add secp256r1 support #1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispc
reviewed
Oct 28, 2024
lispc
reviewed
Oct 28, 2024
lispc
reviewed
Oct 28, 2024
lispc
reviewed
Oct 28, 2024
lispc
reviewed
Oct 28, 2024
lispc
reviewed
Oct 28, 2024
lispc
reviewed
Oct 28, 2024
general seems good.
|
done ! |
@roynalnaruto would you have some time to do a quick review on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to support secp256r1(p256) precompile from circuit side, below are works on signature circuit side, not include evm circuit(buss mapping), l2geth_util etc.
SignData
to generic typeSignData<Fq, Affine>
PrecompileEvents
and provide method to get p256 signature dataassign_ecdsa
to support new secp256r1sign_data_decomposition
to support secp256r1assign_sig_verify
to support secp256r1is_on_curve_or_infinity
applicable to secp256r1MAX_NUM_SIG
,LOOKUP_CELLS_PER_SIG
,CELLS_PER_SIG
?Issue Link
[link issue here]
Type of change