Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add secp256r1 support #1351

Merged
merged 72 commits into from
Oct 30, 2024
Merged

feat: add secp256r1 support #1351

merged 72 commits into from
Oct 30, 2024

Commits on Jun 27, 2024

  1. update SignData with generic type

    @DreamWuGit
    DreamWuGit committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2d238e3 View commit details
    Browse the repository at this point in the history

  2. update PrecompileEvent::SignData

    @DreamWuGit
    DreamWuGit committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f430f3d View commit details
    Browse the repository at this point in the history

  3. update some SignDatas

    @DreamWuGit
    DreamWuGit committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    29f7c34 View commit details
    Browse the repository at this point in the history

  4. add sig circuit signatures_r1

    @DreamWuGit
    DreamWuGit committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1b7d0f2 View commit details
    Browse the repository at this point in the history

  5. change tx circuit regarding signdata

    @DreamWuGit
    DreamWuGit committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9c59cf3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. sig table adds p256 signatures

    @DreamWuGit
    DreamWuGit committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ca79ecc View commit details
    Browse the repository at this point in the history

  2. add ecdsa_r1_config

    @DreamWuGit
    DreamWuGit committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    fb1d74a View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. add FpChipR1 type

    @DreamWuGit
    DreamWuGit committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    435c392 View commit details
    Browse the repository at this point in the history

  2. fix comment

    @DreamWuGit
    DreamWuGit committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    bdff1f7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feat/secp256r1

    @DreamWuGit
    DreamWuGit authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    aad86aa View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. rename FpChip

    @DreamWuGit
    DreamWuGit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ffd9263 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. add assign_ecdsa_generic method

    @DreamWuGit
    DreamWuGit committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7272aa1 View commit details
    Browse the repository at this point in the history

  2. fix assign_ecdsa_generic issue

    @DreamWuGit
    DreamWuGit committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    01e6f94 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. update sign_data_decomposition_generic

    @DreamWuGit
    DreamWuGit committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    71d64fe View commit details
    Browse the repository at this point in the history

  2. make pk_bytes_le_generic helper

    @DreamWuGit
    DreamWuGit committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    be10b33 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. apply sign_data_decomposition_generic

    @DreamWuGit
    DreamWuGit committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0d72669 View commit details
    Browse the repository at this point in the history

  2. add assign_sig_verify_generic

    @DreamWuGit
    DreamWuGit committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    266fc75 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. apply assign_sig_verify_generic

    @DreamWuGit
    DreamWuGit committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    9c35569 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. ecdsa_r1_config.range load lookup

    @DreamWuGit
    DreamWuGit committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    65a80f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. update existing sig circuit tests

    @DreamWuGit
    DreamWuGit committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1ebd7bf View commit details
    Browse the repository at this point in the history

  2. add helper sign_generic

    @DreamWuGit
    DreamWuGit committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cf4ccef View commit details
    Browse the repository at this point in the history

  3. rename sign_generic to sign and remove old method

    @DreamWuGit
    DreamWuGit committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b469244 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. add new test p256_sign_verify

    @DreamWuGit
    DreamWuGit committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e6d5784 View commit details
    Browse the repository at this point in the history

  2. add random msg_hash test

    @DreamWuGit
    DreamWuGit committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    15476f3 View commit details
    Browse the repository at this point in the history

  3. add sign_verify and rename old

    @DreamWuGit
    DreamWuGit committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    116a56b View commit details
    Browse the repository at this point in the history

  4. sign_verify fill with k1 & r1 test data

    @DreamWuGit
    DreamWuGit committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fea64c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. msg_hash == 0 case

    @DreamWuGit
    DreamWuGit committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    29ea9b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. sync develop branch

    @DreamWuGit
    DreamWuGit committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    748ec0b View commit details
    Browse the repository at this point in the history

  2. fix merge error

    @DreamWuGit
    DreamWuGit committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    54207ec View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. update cargo for halo2-lib version

    @DreamWuGit
    DreamWuGit committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4650850 View commit details
    Browse the repository at this point in the history

  2. replace FqChipK1

    @DreamWuGit
    DreamWuGit committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d26cdb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. two chips use one RangeConfig & remove

    @DreamWuGit
    DreamWuGit committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    faf30bd View commit details
    Browse the repository at this point in the history

  2. keccak lookup for r1 pk hash

    @DreamWuGit
    DreamWuGit committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b9c76ec View commit details
    Browse the repository at this point in the history

  3. fix keccak input bytes

    @DreamWuGit
    DreamWuGit committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0204f98 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. misc update

    @DreamWuGit
    DreamWuGit committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    24916f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. add temp debug info

    @DreamWuGit
    DreamWuGit committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5ac53a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. revert temp two RangeChip

    @DreamWuGit
    DreamWuGit committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    92f8040 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. p256 not check v & y oddness match

    @DreamWuGit
    DreamWuGit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    14d0184 View commit details
    Browse the repository at this point in the history

  2. add helper is_p256_precompile

    @DreamWuGit
    DreamWuGit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    76df7bf View commit details
    Browse the repository at this point in the history

  3. add p256 crate test

    @DreamWuGit
    DreamWuGit committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    9e63de1 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. add verify sig helper

    @DreamWuGit
    DreamWuGit committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    0fd1512 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. tests against p256 branch

    @DreamWuGit
    DreamWuGit committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9092084 View commit details
    Browse the repository at this point in the history

  2. comment out p256 crate test

    @DreamWuGit
    DreamWuGit committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cb98f49 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. update halo2-lib branch & ecc_circuit::decompose_ec_mul_op

    @DreamWuGit
    DreamWuGit committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8300bf7 View commit details
    Browse the repository at this point in the history

  2. remove debug info

    @DreamWuGit
    DreamWuGit committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2c77320 View commit details
    Browse the repository at this point in the history

  3. max_verify into max_verify_k1&max_verify_r1

    @DreamWuGit
    DreamWuGit committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    262dc23 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. update test per max_verify

    @DreamWuGit
    DreamWuGit committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    45c4487 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. pad default sigdata

    @DreamWuGit
    DreamWuGit committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    40f5d6c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. fix pad sig lookup

    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b12de56 View commit details
    Browse the repository at this point in the history

  2. pad default

    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    96c48a5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feat/secp256r1

    @DreamWuGit
    DreamWuGit authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b3e0d6e View commit details
    Browse the repository at this point in the history

  4. update types

    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    212e1b0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feat/secp256r1' of https://github.com/scroll-tech/zkevm… 

    …-circuits into feat/secp256r1
    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    01bd0d1 View commit details
    Browse the repository at this point in the history

  6. clippy & comment

    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ab99141 View commit details
    Browse the repository at this point in the history

  7. modify test

    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cd7d774 View commit details
    Browse the repository at this point in the history

  8. remove unused codes of sig circuit

    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    402b1c6 View commit details
    Browse the repository at this point in the history

  9. adjust MAX_NUM_SIG_K1&R1

    @DreamWuGit
    DreamWuGit committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    78d85e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Update utils.rs

    @lispc
    lispc authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a045cda View commit details
    Browse the repository at this point in the history

  2. Update sig_circuit.rs

    @lispc
    lispc authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    859ef81 View commit details
    Browse the repository at this point in the history

  3. Update utils.rs

    @lispc
    lispc authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    980b8d9 View commit details
    Browse the repository at this point in the history

  4. Update utils.rs

    @lispc
    lispc authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a9c5b20 View commit details
    Browse the repository at this point in the history

  5. Update utils.rs

    @lispc
    lispc authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4853bcb View commit details
    Browse the repository at this point in the history

  6. const limbits, num_limbs

    @DreamWuGit
    DreamWuGit committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8116b60 View commit details
    Browse the repository at this point in the history

  7. increase COLUMN_NUM_LIMIT

    @DreamWuGit
    DreamWuGit committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    267d759 View commit details
    Browse the repository at this point in the history

  8. use accurate CELLS_PER_SIG, adjust min_num

    @DreamWuGit
    DreamWuGit committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    355e337 View commit details
    Browse the repository at this point in the history

  9. handle padding in get_sign_data_p256

    @DreamWuGit
    DreamWuGit committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a864510 View commit details
    Browse the repository at this point in the history

  10. try keccak

    @DreamWuGit
    DreamWuGit committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    991bee2 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. disable assigned_keccak_values_r1 & clean

    @DreamWuGit
    DreamWuGit committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1566e61 View commit details
    Browse the repository at this point in the history

  2. enable assigned_keccak_values_r1

    @DreamWuGit
    DreamWuGit committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e920030 View commit details
    Browse the repository at this point in the history

  3. clippy

    @DreamWuGit
    DreamWuGit committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6158319 View commit details
    Browse the repository at this point in the history

  4. clippy

    @DreamWuGit
    DreamWuGit committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    dc4bfd9 View commit details
    Browse the repository at this point in the history

  5. fix fmt

    @DreamWuGit
    DreamWuGit committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    308ede9 View commit details
    Browse the repository at this point in the history