Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add da-avail feature flag #1433

Merged
merged 38 commits into from
Nov 5, 2024
Merged

Add da-avail feature flag #1433

merged 38 commits into from
Nov 5, 2024

Conversation

z2trillion
Copy link
Member

@z2trillion z2trillion commented Oct 17, 2024 •
edited
Loading

When set, this flag disables the eip-4844 blob consistency checks that we currently do.

@lispc lispc requested a review from darth-cy October 18, 2024 09:12
@z2trillion z2trillion changed the title Add da-eip4844 and da-avail feature flags Add da-avail feature flag Oct 22, 2024
@z2trillion z2trillion marked this pull request as ready for review October 22, 2024 02:07
darth-cy
darth-cy reviewed Oct 28, 2024
View reviewed changes
Copy link

@darth-cy darth-cy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm not running the tests correctly. Some tests encountered issues when da-avail feature flag is turned on. Other parts look good to me. In addition to adding the avail feature, it's an effective refactor as well.

Edit: Base branch is ahead.

aggregator/src/batch.rs Outdated Show resolved Hide resolved
aggregator/src/batch.rs Outdated Show resolved Hide resolved
aggregator/src/blob_consistency/avail.rs Show resolved Hide resolved
aggregator/src/blob_consistency.rs Show resolved Hide resolved
@z2trillion
Copy link
Member Author

Maybe I'm not running the tests correctly. Some tests encountered issues when da-avail feature flag is turned on. Other parts look good to me. In addition to adding the avail feature, it's an effective refactor as well.

The tests won't pass when the da-avail flag is set, but this is intended. The tests will pass once the da-avail circuits are added.

@z2trillion z2trillion merged commit 487c83e into develop Nov 5, 2024
17 checks passed
@z2trillion z2trillion deleted the feat/avail-da branch November 5, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darth-cy darth-cy darth-cy approved these changes

@roynalnaruto roynalnaruto Awaiting requested review from roynalnaruto

Assignees
No one assigned
Labels
crate-prover
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z2trillion @darth-cy