Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add da-avail feature flag #1433

Merged
merged 38 commits into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
3975fed
Add data_availibility directory
z2trillion Sep 27, 2024
570a234
move files around and change paths
z2trillion Sep 27, 2024
52b2ac0
rename and move decode_blob
z2trillion Sep 27, 2024
0c568b8
unpub barycentric
z2trillion Sep 27, 2024
4732f8e
move eip4844 files into data_availability/
z2trillion Oct 1, 2024
aa24c73
export functions and structs only
z2trillion Oct 8, 2024
95f812c
move get_bytes to decoder
z2trillion Oct 8, 2024
62e8f2c
Add BlobConsistencyWitness and BlobConsistencyConfig
z2trillion Oct 8, 2024
b7d9410
don't export get_versioned_hash
z2trillion Oct 8, 2024
e622405
cleanup
z2trillion Oct 8, 2024
28d43b2
Move blob_data up to data_availability
z2trillion Oct 8, 2024
91c3a92
fix backwards compatibility
z2trillion Oct 8, 2024
085d417
fix rebase
z2trillion Oct 14, 2024
95933a6
fix warnings
z2trillion Oct 14, 2024
2e1f8d1
remove empty file
z2trillion Oct 14, 2024
a878290
add and use blob_crts_limbs function
z2trillion Oct 16, 2024
11c6e24
add blob_crts_limbs to AssignedBlobDataExport
z2trillion Oct 16, 2024
4fe6c77
move link out of blob data circuit into aggregation circuit
z2trillion Oct 17, 2024
1b710b2
remove unused arguments
z2trillion Oct 17, 2024
f949f98
unpub get_coefficients
z2trillion Oct 22, 2024
6e6ced8
rename data_availability to blob_consistency
z2trillion Oct 22, 2024
de4c88f
remove da-eip4844 feature flag
z2trillion Oct 22, 2024
4634548
Merge branch 'develop' into feat/avail-da
z2trillion Oct 22, 2024
9706829
define N_DATA_BYTES_PER_COEFFICIENT once
z2trillion Oct 22, 2024
2fc9263
fix da-avail build
z2trillion Oct 22, 2024
76a6a70
fix typos
z2trillion Oct 22, 2024
7994fe0
allow dead code for now
z2trillion Oct 22, 2024
ca91110
cleanup comments
z2trillion Oct 29, 2024
36d44aa
Don't use BlobConsistencyWitness in BatchHeader
z2trillion Oct 30, 2024
1581f5a
don't derive (De)serialize
z2trillion Oct 30, 2024
67e2107
add conversion functions
z2trillion Oct 30, 2024
2ec09ae
cleanup
z2trillion Oct 30, 2024
e3cf8ac
Merge branch 'develop' into feat/avail-da
z2trillion Oct 30, 2024
b50708e
fix da-avail build
z2trillion Oct 30, 2024
415d5bc
fix clippy
z2trillion Oct 31, 2024
f90269e
move function to be before tests
z2trillion Oct 31, 2024
7c9b737
cargo fmt
z2trillion Oct 31, 2024
b99bfed
Merge branch 'develop' into feat/avail-da
z2trillion Oct 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ anyhow = "1.0"
ark-std = "0.3"
base64 = "0.13.0"
bincode = "1"
cfg-if = "1"
ctor = "0.1"
env_logger = "0.10"
ethers = { version = "=2.0.7", features = ["ethers-solc"] }
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ test-benches: ## Compiles the benchmarks

test-all: fmt doc clippy test-doc test-benches test ## Run all the CI checks locally (in your actual toolchain)

test-da-avail: ## Run light tests
@cargo test --release --workspace --exclude integration-tests --exclude circuit-benchmarks --features da-avail batch_circuit

super_bench: ## Run Super Circuit benchmarks
@cargo test --profile bench bench_super_circuit_prover -p circuit-benchmarks --features benches -- --nocapture

Expand Down
2 changes: 2 additions & 0 deletions aggregator/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ gadgets = { path = "../gadgets" }
zkevm-circuits = { path = "../zkevm-circuits", default-features=false, features = ["debug-annotations", "parallel_syn"] }

ark-std.workspace = true
cfg-if.workspace = true
ctor.workspace = true
env_logger.workspace = true
ethers-core.workspace = true
Expand Down Expand Up @@ -47,6 +48,7 @@ csv = "1.1"
default = ["revm-precompile/c-kzg", "halo2_proofs/circuit-params"]
display = []
print-trace = ["ark-std/print-trace"]
da-avail = []

[lints]
workspace = true
14 changes: 4 additions & 10 deletions aggregator/src/aggregation.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
/// Config to evaluate blob polynomial at a random challenge.
mod barycentric;
/// Config to constrain batch data (decoded blob data)
mod batch_data;
/// Config to constrain blob data (encoded batch data)
mod blob_data;
pub mod batch_data;
/// Circuit implementation of aggregation circuit.
mod circuit;
/// Config for aggregation circuit
Expand All @@ -15,13 +11,11 @@ mod rlc;
/// Utility module
mod util;

pub(crate) use barycentric::{
interpolate, AssignedBarycentricEvaluationConfig, BarycentricEvaluationConfig, BLS_MODULUS,
};
pub use batch_data::BatchData;
pub(crate) use batch_data::BatchDataConfig;
pub(crate) use blob_data::BlobDataConfig;
pub use decoder::{decode_bytes, encode_bytes};
pub(crate) use decoder::{witgen, DecoderConfig, DecoderConfigArgs};
pub(crate) use rlc::RlcConfig;
pub(crate) use rlc::{RlcConfig, POWS_OF_256};

pub use circuit::BatchCircuit;
pub use config::BatchCircuitConfig;
Loading
Loading