Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sopel 8 preparations #47

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Sopel 8 preparations #47

merged 3 commits into from
Nov 2, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Nov 2, 2023

  • Fixed deprecated import (sopel.module -> sopel.plugin)
  • Switch to BooleanAttribute instead of ValidatedAttribute with bool as parser
  • Just calculate °C -> °F by formula instead of importing non-public function in core

Note that all of these changes are still compatible with Sopel 7.1+ and do not require 8.0.

@dgw dgw added the enhancement New feature or request label Nov 2, 2023
@dgw dgw mentioned this pull request Nov 2, 2023
Merged
@RustyBower RustyBower merged commit cdfb01f into master Nov 2, 2023
4 checks passed
@dgw dgw deleted the sopel-8-ready branch November 4, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RustyBower RustyBower RustyBower approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @RustyBower