Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): enhance controlled behavior of SearchInput using selectionStart and selectionEnd for cursor position preservation #800

Merged
merged 2 commits into from
Sep 3, 2023

feat: utilize the `selectionStart` and `selectionEnd` properties to p…

977b96e
Select commit
Loading
Failed to load commit list.
Merged

feat(react): enhance controlled behavior of SearchInput using selectionStart and selectionEnd for cursor position preservation #800

feat: utilize the `selectionStart` and `selectionEnd` properties to p…
977b96e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 31, 2023 in 1s

71.72% (+0.06%) compared to a80d4cc

View this Pull Request on Codecov

71.72% (+0.06%) compared to a80d4cc

Details

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (a80d4cc) 71.66% compared to head (977b96e) 71.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   71.66%   71.72%   +0.06%     
==========================================
  Files         373      374       +1     
  Lines        6221     6236      +15     
==========================================
+ Hits         4458     4473      +15     
  Misses       1763     1763              
Files Changed Coverage Δ
packages/react/src/search-input/SearchInput.js 73.07% <100.00%> (+4.18%) ⬆️
packages/react/src/utils/useRunAfterUpdate.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.