moved defaultProps to Javascript default parameters #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for xelah-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for xelah-type-perf-html ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only changes made were to move defaultProps to Javascript default parameters, indented to eliminate the following warning: "Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead."
Thank you for your excellent work and contribution in making this monorepo available. I hope this tiny bit of pitching in will save you a little time at some point in the future!
For testing, both styleguides were loaded on local host without any console errors, with successful clicking around on buttons presented in default examples.