Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

fix(vault): Address Vault related issues #331

Merged
merged 11 commits into from
Aug 28, 2023
Merged

fix(vault): Address Vault related issues #331

merged 11 commits into from
Aug 28, 2023

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Aug 21, 2023

In this PR:

  • Fix V2: Failed to initialize Credential manager #324
  • Updated the workflows to be ready to publish via workfow_dispatch
  • Update .gitignore to exclude some dev-generated files
  • Added the .env file to the launch.json configuration
  • Removed .md files from the update.licenses.js script

TODO:

Note:

  • You may run into Unable to load in Zowe Explorer 2.8 cics-for-zowe-client#34
    • I worked around it by installing the plugin with the cli and running zowe config schema > ~/.zowe/zowe.schema.json
    • Another workaround is to run the Initialize Team Configuration File (a.k.a. zowe.all.config.init) command from the command palette
      • This may show the prompt below... Just hit the "Create New" button
        image

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 linked an issue Aug 21, 2023 that may be closed by this pull request
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…rom sessionExpansionHandler

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 marked this pull request as ready for review August 25, 2023 14:27
@zFernand0
Copy link
Member Author

After this is merged, I will kickoff the workflow to publish a new 2.3.1 of CICS. 😋

Copy link
Collaborator

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for your work on this @zFernand0

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few questions about the workflows 🙂

.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0
Copy link
Member Author

zFernand0 commented Aug 28, 2023

We should be ok to merge this PR, even though the deploy step will run (and likely fail).
The deployment is intended to publish the extension when triggered manually from the Actions tab 😋
After a 2.3.1, we can disable the workflow again! 😋

@zFernand0 zFernand0 merged commit 220ab10 into main Aug 28, 2023
10 checks passed
@zFernand0 zFernand0 deleted the fix-324 branch August 28, 2023 14:08
@github-actions
Copy link
Contributor

Release failed for the main branch. 😢

Error: The process '/usr/bin/git' failed with exit code 128
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/master/dist/git.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/master/dist/git.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/master/dist/git.js:863:21)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1100:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

@github-actions
Copy link
Contributor

Release failed for the main branch. 😢

Error: The process '/opt/hostedtoolcache/node/18.17.1/x64/bin/npx' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/zowe-actions/octorelease/master/dist/vsce.js:974:21)
    at ExecState.CheckComplete (/home/runner/work/_actions/zowe-actions/octorelease/master/dist/vsce.js:960:16)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/master/dist/vsce.js:863:21)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1100:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2: Failed to initialize Credential manager
4 participants