Provide API for registering callback upon watcher triggered for exten… #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
- Coverage 92.62% 92.62% -0.01%
==========================================
Files 98 98
Lines 9414 9425 +11
Branches 1951 1952 +1
==========================================
+ Hits 8720 8730 +10
- Misses 693 694 +1
Partials 1 1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
traeok
requested changes
Aug 1, 2023
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
|
Thanks for the suggestions @traeok it should be ready for review now :) |
zFernand0
previously approved these changes
Aug 16, 2023
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
traeok
reviewed
Aug 18, 2023
1 task
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
16 tasks
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/zowe-explorer/__tests__/__unit__/api/ZoweExplorerApiRegister.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
zFernand0
approved these changes
Aug 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
traeok
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
LGTM! Verified that events are being fired from extenders that implement IApiRegisterClient. Thanks for this enhancement and for updating to use vscode.Event @rudyflores 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2385
Proposed changes
Added API for allowing extenders to register their own callback or set of actions to be performed upon the watcher being triggered (create, update, delete) in order to have a way to notify extenders on any real time changes made to a Zowe team config profile.
Release Notes
Milestone: 2.10.0
Changelog: Added API for registering callback function to execute upon triggering the watcher for team config profiles.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments