-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom pull request template paths #4814
feat: add support for custom pull request template paths #4814
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ebe493c
to
65482da
Compare
About the pre-styled message, look for |
Yeah i tried that initially, but the EDIT: Ahh I see, since the |
Actually, I was the one confused. I see we use |
e2f3840
to
3856360
Compare
@PavelLaptev pinging you for the UI / copy of this preferences section What do you think? This is in the project preferences: |
The code looks good to me 👍 |
28519fa
to
558d79f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndom91 thanks! lgtm
i would have expected that Gitbutler auto detects the existance of the template. The paths are pre-determined by GitHub. I think, it are three (times two because of casing). See: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository I agree, users can specify more in a directory Reason: GitButler is interacting with GitHub directly, not with arbitrary platforms. Thus, GitButler should make it convenient to interact with GitHub. |
@koppor thanks for the suggestion, I think if we check the few case-variants and then potentially list hte contents of a |
☕️ Reasoning
.github/PULL_REQUEST_TEMPLATE.md
and.github/pull_request_template.md
about 50/50. There is also technically an option for folks to put their template anywhere under.github/PULL_REQUEST_TEMPLATE/*.md
🧢 Changes
📺 Screenshots