Standup Notes 2020 06 08

Participants (alphabetical): Allie, Conor, Erik, Jen, John, Kevin, Kushal

Topics and Call-outs

• SecureDrop 1.4.0

  • RC1

    • Conor approved wrong tag, packages had to be rebuilt

    • Requesting review of new rc1 LFS packages https://github.com/freedomofpress/securedrop-dev-packages-lfs/pull/44

    • Allie/Conor to work on test plan later today; Kev to support if available

  • Kev to propose docs merge strategy in follow-up PR to #5241

• Type annotation PR causing CI failure by pylint: https://github.com/freedomofpress/securedrop/pull/5298

  • Jen to do additional research

• Old community PR for pagination in the JUI: https://github.com/freedomofpress/securedrop/pull/3719 - may need significant attention, but contributor is interested in picking it up again

  • John to take a first pass, make recommendation whether or not to introduce this functionality to legacy UI

Reminder: Please take contributor survey (see pinned link on Slack #securedrop)

Allie

Yesterday: (Thursday)

• Released packages for Tor
• Started release of 1.4.0
• Documented process with a bit more detail in prep for docs PR

Today:

• Synced up with Kushal re: how to organize test strings in https://github.com/freedomofpress/securedrop/pull/5224
• Review https://github.com/freedomofpress/securedrop-dev-packages-lfs/pull/44
• Finish docs update on release/tagging process, especially around deleting the tag file and recreating one to sign it
• Create test plan for release

Blockers or Asks:

• None

Conor

Yesterday:

• PTO Friday
• On Thursday, worked on 1.4.0-rc1 (tag and packages), submitted PR: https://github.com/freedomofpress/securedrop-dev-packages-lfs/pull/44

Today:

• Tag for 1.4.0-rc1 was incorrect (my mistake!), LFS PR denied
• This morning, retagged 1.4.0-rc1 manually, then rebuilt. LFS PR ready for review: https://github.com/freedomofpress/securedrop-dev-packages-lfs/pull/44
• Test plan for 1.4.0 w/ Allie, likely Kev too for early review

Blockers or Asks:

• requesting review on the rc1 lfs pr! (Allie & Jen volunteered)
• Kev: heads up on test plan review

Erik

Yesterday: (Friday)

• Addressed remaining comments in updater PR ( https://github.com/freedomofpress/securedrop-workstation/pull/528 ), re-tested;
• Tested Redmine bulk announce script against Redmine 4; made some improvements along the way
• Started on black formatter changes for securedrop-workstation, a bit trickier due to file discoverability issues (draft PR: https://github.com/freedomofpress/securedrop-workstation/pull/569 )

Today:

• Prep (pre-)release comms for SD 1.4.0
• Update my Qubes staging env to RC1; test keyring update for SecureDrop Workstation
• Poke at black formatter PR for workstation if time permits

Blockers or Asks: None right now but comments on workstation #569 appreciated

Jen

Yesterday:

• OOO

Today:

• v behind on comms, catching up
• rc1 will review packages, make sure all looks good
• jen/john look at pylint

Blockers or Asks:

• None

John

Yesterday:

• PTO

Today:

• black/isort
• https://github.com/freedomofpress/securedrop/pull/3719

Blockers or Asks:

• None

Kev

Yesterday:

• Tested fresh install scenario for https://github.com/freedomofpress/securedrop-workstation/pull/563
• Reviewed and approved:
  • https://github.com/freedomofpress/securedrop-debian-packaging/pull/171
  • https://github.com/freedomofpress/securedrop-dev-packages-lfs/pull/45
• (This AM) rereviewed https://github.com/freedomofpress/securedrop-workstation/pull/563

Today:

• followup on #563
• followup on merge strategy for master docs branch
• client call
• testinfra in prod
• maybe 1.4.0 test plan feedback?

Blockers or Asks: None

Kushal

Today:

• https://github.com/freedomofpress/securedrop/pull/5298/

• asked to wait till we decide on how to handle pylint errors due type checking
• https://gist.github.com/kushaldas/884f639e7e823d5e50d7684ff6c15dba have to bring in a lot of extra lines like this one https://gist.github.com/kushaldas/884f639e7e823d5e50d7684ff6c15dba
• maybe mark those lines for not QA under pylint

• https://github.com/freedomofpress/securedrop/pull/5284
  • I could not find the said functional test there
• https://github.com/freedomofpress/securedrop-client/pull/1089
  • commented my initial findings on building Qt
• https://github.com/freedomofpress/securedrop/pull/5241
  • reviewed and merged
• Meeting with allie about client test data creation

Tomorrow:

• pick up on client test data creation via special strings Blockers or Asks:

• None

Nina

Yesterday:

• "Codename" research researchings
• Read/Unread sketching

Today:

• More Read/Unread ideation
• 1/2 day SecureDrop, AM with SimSec

Blockers or Asks:

• Erik, late-day review of wires?