Skip to content

Standup Notes 2020 10 13

Jump to bottom
Erik Moeller edited this page Oct 14, 2020 · 1 revision

Participants (alphabetical): Allie, Conor, Erik, John, Kevin, Kushal, Mickael, Ro

Topics and Call-outs

Next steps on badges PR

  • Mickael will review Allie's comments, merge

Template consolidation review

https://github.com/freedomofpress/securedrop-proxy/pull/79 -> Mickael will review, along with https://github.com/freedomofpress/securedrop-workstation/pull/619

Type annotation PRs

Likely John/Kushal

Dev Focal PR

https://github.com/freedomofpress/securedrop/pull/5544

  • Kev will take a look at the pytest & requirements changes

Allie

Yesterday:

  • Worked on end-to-end implementation of read/unread and now ready to generate new SDK cassettes and open an SDK PR
  • Discussed order of operations for the seen feature and database migrations

Today:

  • Review SDK PR
  • Generate new SDK cassettes and new tests and open SDK PR
  • Open a seen db migration PR in the client that allows null journalist ids (we can address the foreign key issue on the server first, then address it client-side)

Blockers or Asks:

  • None

Conor

Yesterday:

  • Debrief on template consolidation, planning revisions before final review
  • Learning time - reproducible builds, hurray

Today:

  • Demo rehearsal for Workstation presentation tomorrow w/ Ro
  • Follow up on template-consolidation: rewrite draft PR descriptions. securedrop-proxy PR can be reviewed, will update.
  • Stretch goal: attempt bash -> python conversion of migration logic for template-consolidation logic

Blockers or Asks:

  • SDO prod migration coming this week, watch calendar for db freeze window (likely Weds or Thurs)

Erik

Yesterday: (Friday)

  • Finished SDK changes for /users endpoint

Today:

  • Finish Salt cleanup for sd-log fix
  • Sprint prep; other work on sprint as time allows

Blockers or Asks: None

Joan

Yesterday:

Today:

Blockers or Asks:

John

Yesterday:

  • i18n improvements (translator credits, fixing some non-pluralized source strings)
  • Learning time (tracker automation)

Today:

Blockers or Asks:

  • None

Kev

Yesterday:

Today:

Blockers or Asks: None

Kushal

Today:

  • Reviewed SDK authentication PR #135
  • Updated #5544 dev-focal PR

Tomorrow:

  • def-focal PR
  • Type annotation PRs as needed

Blockers or Asks: None

Mickael

Yesterday:

Today:

  • Review across a few repos
  • Opened PR to remove Pipfile from SDK repo
  • Fix hardware issues
  • Review Allie's comments in reply badge PR
  • Look at template consolidation PR
  • Plan follow-up for safe deleton project

Blockers or Asks: None

Ro

Today:

  • ONA talk prep
  • support comms
  • docs tasks

Blockers or Asks: -none

Clone this wiki locally